-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add new version of readme #105
Conversation
/assign @RainbowMango @samzong |
560dc97
to
fb8845e
Compare
``` | ||
When finish Karmada-dashboard can be accessed by http://your-karmada-host:30486 | ||
When the process of installation finished, you can visit the karmada dashboard by http://your-karmada-host:32000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the process of installation finished, you can visit the karmada dashboard by http://your-karmada-host:32000 | |
When the process of installation is finished, you can visit the karmada dashboard at `http://your-karmada-host:32000`. | |
If your Karmada was installed on a Kind cluster(just as per the [tutorial](https://karmada.io/docs/installation/#install-karmada-for-development-environment)), you might need to expose the service by kubectl port-forward, like: | |
`kubectl port-forward -n karmada-system services/karmada-dashboard-web --address 0.0.0.0 32000:8000`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we need to change the Kind config for host cluster:
dashboard/artifacts/kindClusterConfig/karmada-host.yaml
Lines 8 to 12 in 8f9b798
extraPortMappings: | |
- containerPort: 5443 | |
hostPort: 5443 | |
protocol: TCP | |
listenAddress: "{{host_ipaddress}}" |
and add extraPortMappings like
- containerPort: 32000
hostPort: 32000
protocol: TCP
listenAddress: "{{host_ipaddress}}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if want to reuse the local-up-karmada.sh in the karmada repo, the extraPortMapping can be inserted through sed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will see. But for now, I don't think so as it works fine on my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will see. But for now, I don't think so as it works fine on my side.
I've tested the extraPortMappings
on my machine, it works for my.
You might have forgotten to commit some files as some comments were not addressed. |
3a3b680
to
896d367
Compare
done. We only leave one unresolved problem for portMapping. |
Signed-off-by: warjiang <1096409085@qq.com>
896d367
to
f295d48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Just rebased and tidy the commits.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
add new readme doc for karmada
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: