kustomize deploy #104
kustomize deploy #104
Conversation
There was a problem hiding this comment.
Why the .gitignore live in this path?
There was a problem hiding this comment.
I will merge this .gitignore file. The reason is that for convinient 😆
f01759a to
4446ac0
Compare
|
@RainbowMango The branch already be rebased, and related problem has been resolved. |
| env: | ||
| - name: GIN_MODE | ||
| value: release |
There was a problem hiding this comment.
What's the environment used for? I searched over the code base but didn't find any reference to it.
There was a problem hiding this comment.
It's the env for gin, more details can refer： https://github.com/gin-gonic/gin/blob/master/mode.go
| @@ -0,0 +1 @@ | |||
| .dockerconfigjson | |||
There was a problem hiding this comment.
I merge the inner .gitignore to the outer one
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Co-authored-by: Hongcai Ren <renhongcai@huawei.com> Signed-off-by: warjiang <1096409085@qq.com>
51beb7e to
41de190
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* deploy: add gin env & update image tag Signed-off-by: warjiang <1096409085@qq.com> * deploy: use kustomize for nodePort mode Signed-off-by: warjiang <1096409085@qq.com> * deploy: use kustomize for ingress mode Signed-off-by: warjiang <1096409085@qq.com> * chore: reformat config file Signed-off-by: warjiang <1096409085@qq.com> * chore: merge ingress-mode/.gitignore into outside .gitignore Signed-off-by: warjiang <1096409085@qq.com> * Update artifacts/dashboard/karmada-dashboard-web.yaml Co-authored-by: Hongcai Ren <renhongcai@huawei.com> Signed-off-by: warjiang <1096409085@qq.com> --------- Signed-off-by: warjiang <1096409085@qq.com> Co-authored-by: Hongcai Ren <renhongcai@huawei.com> Signed-off-by: chouchongYHMing <121396869+chouchongYHMing@users.noreply.github.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
add kustomize style of deploy, support mode of nodePort and ingress
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: