Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helper): Improve useragent detection. #474

Merged

Conversation

dignifiedquire
Copy link
Member

By using the module 3rd-Eden/useragent instead of a homegrown solution
we are able to parse a much wider range of useragent strings.
Fixes #373.

This needs to wait to be merged until 3rd-Eden/useragent#28 is resolved.

@vojtajina
Copy link
Contributor

NICE!!!

Can you make sure it fixes #318 as well ?

@vojtajina
Copy link
Contributor

@dignifiedquire LGTM, merge it once 3rd-Eden/useragent#28 gets out (update the dep in package.json to ~2.0.4)

@dignifiedquire
Copy link
Member Author

New version was just released. I'll rebase and merge tonight.

@ghost ghost assigned dignifiedquire Apr 19, 2013
By using the module 3rd-Eden/useragent instead of a homegrown solution
we are able to parse a much wider range of useragent strings.
Fixes karma-runner#373, karma-runner#318.
dignifiedquire added a commit that referenced this pull request Apr 20, 2013
feat(helper): Improve useragent detection.
@dignifiedquire dignifiedquire merged commit 29eb9fa into karma-runner:master Apr 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable browser name parsing (feature)
2 participants