Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using karma-cli if you are on Windows #1658

Merged
merged 1 commit into from
Oct 22, 2015

Conversation

danielcompton
Copy link
Contributor

This was inspired in part by bensu/doo#46.

Is the recommendation to always use karma-cli, even if you're on Unix where you could run ./node_modules/karma/bin/karma start? Or is running ./node_modules/karma/bin/karma start acceptable if you don't need to be cross platform?

@GitCop
Copy link

GitCop commented Oct 22, 2015

There were the following issues with your Pull Request

  • Commit: 887a995
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@danielcompton
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks :octocat:

dignifiedquire added a commit that referenced this pull request Oct 22, 2015
Recommend using `karma-cli` if you are on Windows
@dignifiedquire dignifiedquire merged commit 0ac89c5 into karma-runner:master Oct 22, 2015
@danielcompton
Copy link
Contributor Author

@dignifiedquire what's the recommendation on using karma-cli when you're on Unix? Is it ok to call ./node_modules/karma/bin/karma start, or is it still recommended to use karma-cli?

@dignifiedquire
Copy link
Member

no specific recommendation, depends on your preference really

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants