Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage reporter broke after testacular -> karma switch #461

Closed
mourner opened this issue Apr 4, 2013 · 2 comments
Closed

Coverage reporter broke after testacular -> karma switch #461

mourner opened this issue Apr 4, 2013 · 2 comments

Comments

@mourner
Copy link

mourner commented Apr 4, 2013

Today I discovered that coverage report in my project (https://github.com/Leaflet/Leaflet/) stopped working — generated report is empty. With git bisect, I tracked it down to this commit that broke it: jfirebaugh/Leaflet@28daa9e
The only change is rename/update from Testacular to Karma.

Maybe you have any clue how it could broke coverage reporting? Thanks.
@mourner mourner mentioned this issue Apr 4, 2013
Merged
mourner added a commit to Leaflet/Leaflet that referenced this issue Apr 4, 2013
@mourner
fix coverage reporting in Karma #1479, close karma-runner/karma#461
6c7316d
@mourner mourner closed this as completed Apr 4, 2013
@mourner
Copy link
Author

mourner commented Apr 4, 2013

OK, managed to figure it out (after skimming through commits). But there was no mention in changelog that anything has changed with path resolving, it would be nice to update it...

mourner added a commit to Leaflet/Leaflet that referenced this issue Apr 4, 2013
@mourner
Merge branch 'master' into gridlayer
44d5bf4 
* master:
  fix coverage reporting in Karma #1479, close karma-runner/karma#461
  Update specs for mocha
  Manage mocha dependency with npm; update to 1.9.0
  Update mocha.js
  remove testacular master hack (as 0.6 is now stable)
  Proper default for delta
  Tighter tolerance for point-near check
  Fix mercator tests, these are broken in Leaflet master.
  Use mocha
  testacular -> karma
  remove testacular master hack (as 0.6 is now stable)
  Update deps.js
  Strage behavior of inplace github editor
  Remove trailing whitespace in fix
  Extend L.Util.template
  Popup close button bugfix
@vojtajina
Copy link
Contributor

Yep, preprocessors patterns are resolved in the same way as any other pattern. It's mention in 0.8.1 release as "preprocessor: resolve relative patterns to basePath (a4c7d19, closes #382)".

It's not in breaking changes, because I didn't realize it could break anybody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mourner @vojtajina