fix: kill all IE processes when terminating browser process

[sylvain-hamel]

closes #15

[cthorne66]

I tested the updates, and still see one iexplorer.exe instance staying open in the background. When I end that last instance manually, my CI (Jenkins) finally confirms the results.

Without manually killing, it just hangs & waits.

This being said, there are no browsers visible during the issue, as they are closed from sight

[sylvain-hamel]

Does the iexplore.exe that stays there have command line args that look like this:

SCODEF:2632 CREDAT:275457 /prefetch:2

You can find this out by adding the command line column in Task Manager.

[sylvain-hamel]

In fact there are two fixes to fix this bug

1. fix(web-server): implement a timeout on webServer.close() karma#973 is the fix that is supposed to end IE correctly.
2. This fix here is to end extra iexplor.exe processes that stay open.

Can you please try both fixes together and let me know.

[cthorne66]

I'm seeing SCODEF:1300 CREDAT:78849 /prefetch:2. Forgot to mention I'm working with IE10 at the moment, but will have to apply the same to a IE11 instance. I will try both of those fixes & let you know. Thank you

[cthorne66]

The confusion was on my end. Your changes are working to close the iexplor.exe, and therefor Jenkins is able to go on with it's work.

+1

Thank you very much!

[sylvain-hamel]

Awesome! Thanks for the update. I should be able to merge this PR this week.

[dignifiedquire]

Please try to define your functions before you use them :)

[sylvain-hamel]

@dignifiedquire this project does not have code style check yet. I'm going to do this in #17. I'd merge this one as-is and fix the all the styles with #17 if you don't mind.

[dignifiedquire]

Sure