Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grunt-karma.js #148

Closed
wants to merge 1 commit into from
Closed

Update grunt-karma.js #148

wants to merge 1 commit into from

Conversation

enigmak
Copy link
Contributor

@enigmak enigmak commented Apr 17, 2015

Fix for bug: arguments to path.resolve must be strings #142

I changed the grunt-karma.js file by adding data.files =_.flatten(data.files); to line 85. The _.flatten used to be there in the 0.9 version and the [].concat is not flattening like it should on my machine.

To test it pass files: [['a.js','b.js','c.js'],'d.js','e.js'] under karma -> options -> files in the config and it will break then add the line of code and it will work.

@dignifiedquire
Copy link
Member

Thanks, could you change the commit message to something following http://karma-runner.github.io/0.12/dev/git-commit-msg.html e.g.

fix: Flatten files array.

Closes #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants