Improve config for display line movement

Switch to keybindings instead of settings Ref: VSCodeVim/Vim#3623 Ref: VSCodeVim/Vim#2924 (comment)
karlhorky · Mar 25, 2019 · a0f8cd5 · a0f8cd5
1 parent 9030c54
commit a0f8cd5
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 36 deletions.
diff --git a/settings/Library/Application Support/Code/User/keybindings.json b/settings/Library/Application Support/Code/User/keybindings.json
@@ -159,11 +159,21 @@
   {
     "key": "up",
     "command": "cursorUp",
-    "when": "editorTextFocus && vim.active && !inDebugRepl && vim.mode == 'Insert' && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
+    "when": "editorTextFocus && vim.active && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
   },
   {
     "key": "down",
     "command": "cursorDown",
-    "when": "editorTextFocus && vim.active && !inDebugRepl && vim.mode == 'Insert' && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
+    "when": "editorTextFocus && vim.active && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
+  },
+  {
+    "key": "k",
+    "command": "cursorUp",
+    "when": "editorTextFocus && vim.active && !inDebugRepl && vim.mode == 'Normal' && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
+  },
+  {
+    "key": "j",
+    "command": "cursorDown",
+    "when": "editorTextFocus && vim.active && !inDebugRepl && vim.mode == 'Normal' && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
   }
 ]
diff --git a/settings/Library/Application Support/Code/User/settings.json b/settings/Library/Application Support/Code/User/settings.json
@@ -20,42 +20,24 @@
   "vim.useSystemClipboard": true,
   // "vim.debug.loggingLevel": "debug",
   // Fix moving down full lines on word wrapped lines https://stackoverflow.com/a/46436056/1268612
-  // "vim.insertModeKeyBindings": [
-  //   // Super hacky fix to arrow key bindings below not working
-  //   // https://github.com/VSCodeVim/Vim/issues/2924
-  //   // TODO: Remove! This makes the § symbol very slow.
+  // "vim.normalModeKeyBindingsNonRecursive": [
   //   {
-  //     "before": ["§"],
-  //     "after": ["§"]
+  //     "before": ["j"],
+  //     "after": ["g", "j"]
   //   },
   //   {
-  //     "before": ["down"],
-  //     "after": ["<C-o>", "g", "j"]
-  //   },
-  //   {
-  //     "before": ["up"],
-  //     "after": ["<C-o>", "g", "k"]
+  //     "before": ["k"],
+  //     "after": ["g", "k"]
   //   }
+  //   // {
+  //   //   "before": ["down"],
+  //   //   "after": ["g", "j"]
+  //   // },
+  //   // {
+  //   //   "before": ["up"],
+  //   //   "after": ["g", "k"]
+  //   // }
   // ],
-  // Fix moving down full lines on word wrapped lines https://stackoverflow.com/a/46436056/1268612
-  "vim.normalModeKeyBindingsNonRecursive": [
-    {
-      "before": ["j"],
-      "after": ["g", "j"]
-    },
-    {
-      "before": ["k"],
-      "after": ["g", "k"]
-    },
-    {
-      "before": ["down"],
-      "after": ["g", "j"]
-    },
-    {
-      "before": ["up"],
-      "after": ["g", "k"]
-    }
-  ],
   "files.trimTrailingWhitespace": true,
   // "eslint.validate": [
   //   "javascript",
@@ -67,9 +49,7 @@
   // ],
   "editor.tabSize": 2,
   "workbench.editor.tabCloseButton": "off",
-  // "eslint.autoFixOnSave": true,
   "eslint.alwaysShowStatus": true,
-  "flow.useNPMPackagedFlow": true,
   "workbench.editor.tabSizing": "shrink",
   "window.newWindowDimensions": "maximized",
   "workbench.editor.showIcons": false,
@@ -81,7 +61,6 @@
   "javascript.validate.enable": false,
   "vim.mouseSelectionGoesIntoVisualMode": false,
   "editor.formatOnSaveTimeout": 5000,
-  // "prettier.tslintIntegration": true,
   "prettier.singleQuote": true,
   "[markdown]": {
     "files.trimTrailingWhitespace": false