-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support uint16/32, and tests added #15
Conversation
Sweet, very nice :) One more thing to make it perfect if you're up for it: tests :D But don't worry, it's easy because the test data is there, it just needs to be called:
If you're feeling a bit more adventurous, you can also add |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 84.00% 83.85% -0.15%
==========================================
Files 59 61 +2
Lines 2938 3035 +97
==========================================
+ Hits 2468 2545 +77
- Misses 313 324 +11
- Partials 157 166 +9
|
did the tests and able to where as having issues getting complex dynamic dtypes work, since idk golang type VarTestStruct struct {
A [1]byte `ssz-size:"2" ssz:"bits"`
// B [1]byte `ssz-size:"2" ssz:"bits" ssz-max:"1024"`
C [1]byte `ssz-size:"1" ssz:"bits"`
}
type ComplexTestStruct struct {
A [1]byte `ssz-size:"2" ssz:"bits"`
// B [1]byte `ssz-size:"2" ssz:"bits" ssz-max:"128"`
C [1]byte `ssz-size:"1" ssz:"bits"`
// D [1]byte `ssz-max:"256"`
E VarTestStruct
// F [1]FixedTestStruct `ssz-size:"4" ssz:"bits"`
// G [1]VarTestStruct `ssz-size:"2" ssz:"bits"`
} have reached til^ sorry, if im wrong w/ things since this is the first time im programming in go- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests green. Thank you for the PR. LGTM! :)
@Lavishq Just one more tip in general, in Go, you can run all the tests from all packages via Thanks again :) |
hm, i know nothing about go, i once did tour of go upto variables and imports, probably a little more for about 20-30 mins and that is all [ also dont remember much ] thanks ser, for bearing with me, it was embarrasing to make silly mistakes but was a learning exp and would do again but maybe after i finish tour of go this time :) |
#12