Add missing string iterator declaration for _.sortBy

kamranayub · Aug 17, 2016 · 9d5b115 · 9d5b115
1 parent 8fbf6cb
commit 9d5b115
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/build/underscore-ko.d.ts b/build/underscore-ko.d.ts
@@ -488,6 +488,10 @@ interface KnockoutObservableArrayFunctions<T> {
      * Mutator version of `_.sortBy`
      */
     sortBy_<TSort>(iterator?: _.ListIterator<T, TSort>, context?: any): T[];
+    /**
+   * Mutator version of `_.sortBy`
+   */
+    sortBy_(iterator: string, context?: any): T[];
     /**
      * Mutator version of `_.groupBy`
      */

diff --git a/build/underscore-ko.js b/build/underscore-ko.js
diff --git a/build/underscore-ko.min.js b/build/underscore-ko.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "underscore-ko",
   "description": "Dead simple utility that attaches Underscore.js array and collection functions (and mutators) to Knockout.js observable arrays.",
-  "version": "1.8.3",
+  "version": "1.8.3.1",
   "author": "Kamran Ayub <http://kamranicus.com>",
   "homepage": "https://github.com/kamranayub/UnderscoreKO",
   "repository": {

diff --git a/src/interface.ts b/src/interface.ts
@@ -672,6 +672,10 @@ interface KnockoutObservableArrayFunctions<T> {
    * Mutator version of `_.sortBy`
    */
   sortBy_<TSort>(iterator?: _.ListIterator<T, TSort>, context?: any): T[];
+	/**
+   * Mutator version of `_.sortBy`
+   */
+	sortBy_(iterator: string, context?: any): T[];
   /**
    * Mutator version of `_.groupBy`
    */