-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build modern CommonJS and support package.json exports #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c6814b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
node16
for building CJSWarning
Unless
moduleResolution
is explicitly set toclassic
,node
ornode10
- thencommonjs
(Node <v12 style CJS) will be used.Output leaves dynamic
import()
calls as-is, so CommonJS can asynchronously import ESM (Node can import ESM from CJS).TypeScript documentation
Node.js v12 security support reached EOL in 2022 (and active support in 2020).
Use
node16
ornodenext
ores2022
for building ESMIf the nearest tsconfig.json's
moduleResolution
is eithernode16
ornodenext
, themodule
will use that value. Otherwise, it'll usees2022
.Aside from building to "modern" CJS, another benefit of using
module: node16
is that it works withmoduleResolution: node16 | nodenext
(allowing the usage ofexports
field in package.json) whereasmodule: commonjs
doesn't.