Skip to content

Commit

Permalink
Fix a source of non-determinism
Browse files Browse the repository at this point in the history
Summary:
Found by reading code, not observed as a problem in practice.
So in practice, this is a behavior-preserving change.

Reviewed By: thezhangwei

Differential Revision: D55774434

fbshipit-source-id: 173adf6b8d5389f0fb85687bb3de9e3284034686
  • Loading branch information
Nikolai Tillmann authored and facebook-github-bot committed Apr 5, 2024
1 parent c018b77 commit afcc6c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion service/class-merging/MergeabilityCheck.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ TypeSet MergeabilityChecker::exclude_unsupported_bytecode_refs_for(
auto use_insn = use.insn;
if (opcode::is_a_move(use_insn->opcode())) {
// Ignore moves
break;
continue;
}
if (!use_insn->has_method()) {
TRACE(CLMG, 5, "[non mergeable] const class unsafe use @ %s in %s",
Expand Down

0 comments on commit afcc6c3

Please sign in to comment.