🏭 Refactor metrics/events send mechanism #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, events and PR were sent asynchronously from callbacks.
It led to metrics not being batched (there were mostly sent one by one). It also led to loss of metrics (and sometimes fully blockage of metrics/events sending mechanism).
Now we have a queue to store pending metrics/events and both are dequeued every 10s.
This should greatly improve stability.
From the code writing perspective it requires to: