fix(FEC-10890): the captions aren't displayed for audio entry and UI doesn't clickable. #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: subtitles container append before poster and located under it on the DOM tree. Solution: add z-index to subtitle to appear above the poster.
yairans
reviewed
Jan 18, 2021
| this._textDisplayEl = Utils.Dom.createElement('div'); | ||
| Utils.Dom.setAttribute(this._textDisplayEl, 'aria-live', 'polite'); | ||
| Utils.Dom.addClassName(this._textDisplayEl, SUBTITLES_CLASS_NAME); | ||
| Utils.Dom.appendChild(this._el, this._textDisplayEl); |
There was a problem hiding this comment.
@Yuvalke what if there is captions at 0 time and preload true. the captions will displayed over the pre-playback screen no?
There was a problem hiding this comment.
@yairans Nothing change for pre-playback(UI) it's an internal change on playkit(playkit-container) for the order it appends on.
Anyway, pre-playback has z-index:1
yairans
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: subtitles container append before poster and located under it on the DOM tree.
Solution: poster, captions, and black screen container blocking user action from UI add pointer-events: none to avoid it.
append captions container after playkit containers.
CheckLists