Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change devtoolModuleFilenameTemplate #115

Merged
merged 3 commits into from
Sep 25, 2017
Merged

chore: change devtoolModuleFilenameTemplate #115

merged 3 commits into from
Sep 25, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Sep 16, 2017 •
edited
Loading

Description of the Changes

Move to be relative to bundle file and also seems to have better support for edge and IE11 that sometimes are hard to find the webpack:/// path

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe
chore: change devtoolModuleFilenameTemplate
e6a5251 
Move to be relative to bundle file and also seems to have better support for edge and IE11 that sometimes are hard to find the webpack:/// path
@OrenMe OrenMe self-assigned this Sep 16, 2017
@OrenMe OrenMe requested a review from dan-ziv September 16, 2017 14:25
@dan-ziv dan-ziv merged commit accce14 into master Sep 25, 2017
@dan-ziv dan-ziv deleted the devtoolModuleFilenameTemplate branch September 25, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@OrenMe OrenMe

Labels
Priority: Low Type: Maintenance
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @dan-ziv