Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8828): cast button is not centered #331

Merged
merged 1 commit into from
Jan 14, 2019
Merged

fix(FEC-8828): cast button is not centered #331

merged 1 commit into from
Jan 14, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 14, 2019 •
edited
Loading

Description of the Changes

set text-align: center;

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jan 14, 2019
@yairans yairans requested a review from a team January 14, 2019 11:13
@yairans yairans mentioned this pull request Jan 14, 2019
Merged
5 tasks
yairans added a commit to kaltura/kaltura-player-js that referenced this pull request Jan 14, 2019
@yairans
fix: remove applicative style (#203)
31e78fc 
Currently we set `text-align: center;` for the `body`, this style is *application* style and hides some bugs from our eyes (e.g. kaltura/playkit-js-ui#327, kaltura/playkit-js-ui#331).
@yairans yairans merged commit 5c11438 into master Jan 14, 2019
@yairans yairans deleted the FEC-8828 branch January 14, 2019 12:39
@yairans yairans changed the title fix(FEC-8827): cast button is not centered fix(FEC-8828): cast button is not centered Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe