Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8778): no watermark is shown in pre-play presentation #319

Merged
merged 2 commits into from
Dec 20, 2018
Merged

fix(FEC-8778): no watermark is shown in pre-play presentation #319

merged 2 commits into from
Dec 20, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Dec 20, 2018

Description of the Changes

Move the watermark and the playlist-countdown outside the player gui and set the css on the playlist countdown which is applied automatically while it was under the player gui.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Dec 20, 2018
@dan-ziv dan-ziv requested review from OrenMe and yairans December 20, 2018 13:23
@dan-ziv dan-ziv merged commit bc23ee4 into master Dec 20, 2018
@dan-ziv dan-ziv deleted the FEC-8778 branch December 20, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @yairans