feat(FEC-8601): Add network requests retry mechanism and headers data to the error #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Nov 14, 2018
OrenMe
suggested changes
Nov 14, 2018
doHTTP is used be other services. changing this requires a bigger change
OrenMe
suggested changes
Nov 15, 2018
src/util/request-builder.js
Outdated
| } | ||
| } catch (error) { | ||
| this._requestPromise.reject(new Error(Error.Severity.CRITICAL, Error.Category.NETWORK, Error.Code.BAD_SERVER_RESPONSE, error)); |
There was a problem hiding this comment.
define BAD_SERVER_RESPONSE error object:
url,
headers,
responseText
src/util/request-builder.js
Outdated
| }; | ||
| request.onerror = error => { | ||
| this._handleError(request, Error.Code.HTTP_ERROR, { | ||
| error |
There was a problem hiding this comment.
remove the error, it is the DOM progress element.
add the status code and text
src/util/request-builder.js
Outdated
| } | ||
|
|
||
| _handleError(request: XMLHttpRequest, code: number, data: Object): Promise<*> | void { | ||
| Object.assign(data, { |
There was a problem hiding this comment.
extract this to _createErrorObject method
1. add MULTIREQUEST_API_ERROR 2. add API_RESPONSE_MISMATCH 3. structurize the error rejects.
OrenMe
suggested changes
Nov 15, 2018
| @@ -41,11 +41,26 @@ export default class MultiRequestBuilder extends RequestBuilder { | |||
| return new Promise((resolve, reject) => { | |||
| this.doHttpRequest().then( | |||
| data => { | |||
| resolve(new MultiRequestResult(data)); | |||
| const multiRequestResult = new MultiRequestResult({ | |||
There was a problem hiding this comment.
no need for object if we reduced to single param
| new Error(Error.Severity.CRITICAL, Error.Category.NETWORK, Error.Code.MULTIREQUEST_API_ERROR, { | ||
| url: this.url, | ||
| headers: this.responseHeaders, | ||
| serviceErrors: multiRequestResult.error |
src/util/request-builder.js
Outdated
| if (request.readyState === 4) { | ||
| request.onreadystatechange = () => { | ||
| if (request.readyState === 4) { | ||
| try { |
There was a problem hiding this comment.
try catch only on JSON.parse
OrenMe
previously approved these changes
Nov 18, 2018
OrenMe
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Adding a new configuration under providers for retrying multi requests:
Added the response headers to the reject data.
CheckLists