Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8751): add support for ima playAdsAfterTime setting #87

Merged
merged 1 commit into from
Jan 13, 2019
Merged

feat(FEC-8751): add support for ima playAdsAfterTime setting #87

merged 1 commit into from
Jan 13, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 13, 2019 •
edited
Loading

Description of the Changes

set playAdsAfterTime according the playback.startTime config

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jan 13, 2019
@yairans yairans requested a review from a team January 13, 2019 12:49
@yairans yairans merged commit e928785 into master Jan 13, 2019
@yairans yairans deleted the FEC-8751 branch January 13, 2019 15:16
@yairans yairans mentioned this pull request Jan 14, 2019
Merged
5 tasks
yairans added a commit to kaltura/kaltura-player-js that referenced this pull request Jan 14, 2019
@yairans
feat(FEC-8751): add support for ima playAdsAfterTime setting (#201)
f4c243d 
remove skipping ads on cast disconnect, as is already handled in kaltura/playkit-js-ima#87 according the `startTime` configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe