Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8209): handle MEDIA_ERR_DECODE errors #60

Merged
merged 3 commits into from
Jun 14, 2018
Merged

feat(FEC-8209): handle MEDIA_ERR_DECODE errors #60

merged 3 commits into from
Jun 14, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented May 12, 2018 •
edited by odedhutzler
Loading

Description of the Changes

Add error handling for html5 video media error MEDIA_ERR_DECODE

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))

@OrenMe OrenMe self-assigned this May 12, 2018
@OrenMe OrenMe requested review from yairans and dan-ziv May 12, 2018 18:38
@OrenMe OrenMe requested a review from odedhutzler June 14, 2018 07:34
@OrenMe OrenMe merged commit 9cc68bd into master Jun 14, 2018
@OrenMe OrenMe deleted the FEC-8209 branch June 14, 2018 07:42
dan-ziv pushed a commit that referenced this pull request Jul 16, 2020
@OrenMe
tests: use kaltura VOD stream and fix tests (#60)
f7ede37 
Use our own stream for VoD testing.
Fix async tests that don't have catch clauses:
```javascript
Promise.then().catch(e => {done(e))
try { ... } catch (e) { done(e); }
```
Fix failing audio tests following #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odedhutzler odedhutzler odedhutzler approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@OrenMe OrenMe

Labels
Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @odedhutzler