Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8841): playlist - the thumbnail slices request is missing ks when the item is already played #210

Merged
merged 1 commit into from
Jan 17, 2019
Merged

fix(FEC-8841): playlist - the thumbnail slices request is missing ks when the item is already played #210

merged 1 commit into from
Jan 17, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 17, 2019 •
edited
Loading

Description of the Changes

pass the current session object to setMedia api

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team January 17, 2019 13:42
@yairans yairans self-assigned this Jan 17, 2019
@yairans yairans merged commit 7e8359f into master Jan 17, 2019
@yairans yairans deleted the FEC-8841 branch January 17, 2019 15:05
@yairans yairans changed the title playlist - the thumbnail slices request is missing ks when the item is already played fix(FEC-8841): playlist - the thumbnail slices request is missing ks when the item is already played Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe