Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8685): when disconnecting from cast player state is wrong - local and cast mode is not in sync #170

Merged
merged 4 commits into from
Nov 13, 2018
Merged

fix(FEC-8685): when disconnecting from cast player state is wrong - local and cast mode is not in sync #170

merged 4 commits into from
Nov 13, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 13, 2018 •
edited
Loading

Description of the Changes

Update playback started event enum => first playing.
In addition, set the initial tracks on tracks changed event and not on playback start event.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Nov 13, 2018
@dan-ziv dan-ziv requested a review from a team November 13, 2018 08:49
OrenMe
OrenMe previously approved these changes Nov 13, 2018
View reviewed changes
@dan-ziv dan-ziv merged commit 263f915 into master Nov 13, 2018
@dan-ziv dan-ziv deleted the FEC-8685 branch November 13, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe