fix(FEC-8382): stereo icon displayed on iPhone, even if VR plugin disabled #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
commented
Jul 5, 2018
| _handleVr(config: ?PKPluginsConfigObject): void { | ||
| if (config) { | ||
| _handleVr(config: PKPluginsConfigObject = {}): void { | ||
| if (config.vr && !config.vr.disable) { |
There was a problem hiding this comment.
Actually, I would like to be sure the plugin is active (maybe its bundle non exist at all?)
But this info is unavailable in kalturaPlayer yet.
That's means, if vr plugin configured and not disabled, the vr button will display in the control bar even the plugin is inactive.
dan-ziv
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
check vr plugin exists and not disable before handling it
CheckLists