Add support for Sphinx 2.0 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Finucane <stephen@that.guru> Closes: #33
|
The tests are failing without this changes. Any ideas, @kallimachos ? |
|
Thanks for the PR @stephenfin. I'll dig into the logs tomorrow and see if I can figure out why the tests are failing. |
|
Thanks. Let me know if there's anything I can do to help. On a side note, I don't know if you've any interest in moving this to the @sphinx-contrib organization. Could help with the maintenance burden. Let me know (here or via email) if you do |
|
Hi @stephenfin. I'm still working on this. A couple of things to start though:
|
|
Python 3-only is good as is moving the extension once all this is resolved |
- use add_css_file() in place of deprecated add_stylesheet() - test against Python 3.7 - update tests
|
@stephenfin I think that's got it. If it looks good to you, I'll go ahead and merge. |
|
Looks good to me, yup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.