Extended Width and Height range options and included this properties for Spotify component #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extended width and height validations to allow auto, % and floating point values - Added setting to allow configuration of additional valid CSS Units for width and height definition. - Corrected _validationMessages_ to use Lang class, because it was presenting the lang key as string instead of the value - Updated Documentation
|
Hi! Thanks for dropping an interesting looking PR. 😎 Looks good on first eyesight, but I'll have to check it out further before merging - as soon as I have some time left over (a day or two.) |
|
How is it @kalfheim? :) |
|
@MicaelRodrigues A day or tow, or 22. Sorry about that 😿 It's all merged and live now. 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_validationMessages_to useLangclass, because it was presenting the lang key as string instead of the value