feat: add featuregate for ensureNodeClass #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
bangqipropel
approved these changes
Feb 27, 2025
ishaansehgal99
approved these changes
Feb 27, 2025
zhuangqh
approved these changes
Feb 27, 2025
bangqipropel
pushed a commit
that referenced
this pull request
Feb 28, 2025
**Reason for Change**: Not all node auto provisioner requires the NodeClass CRD. To minimize the dependency, add the feature gate ensureNodeClass to skip auto generate NodeClass unless it is needed. The feature is false by default. **Issue Fixed**: Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Not all node auto provisioner requires the NodeClass CRD. To minimize the dependency, add the feature gate ensureNodeClass to skip auto generate NodeClass unless it is needed.
The feature is false by default.
Issue Fixed:
#898