-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reorg e2e test code to be reused in RAG e2e tests #834
+244
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b99ab7c
to
30a82eb
Compare
b8e8c5b
to
476b76d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
89d8ef8
to
f1d017c
Compare
71063e0
to
1163799
Compare
c42bf90
to
96494b7
Compare
fc79e17
to
8e7b60c
Compare
8e7b60c
to
529dff6
Compare
bf7b88f
to
bea1016
Compare
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
bea1016
to
d236789
Compare
Fei-Guo
approved these changes
Jan 24, 2025
bangqipropel
added a commit
that referenced
this pull request
Jan 27, 2025
**Reason for Change**: add an e2e base setup file for the duplicate part **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com> Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
bangqipropel
added a commit
that referenced
this pull request
Jan 27, 2025
**Reason for Change**: add an e2e base setup file for the duplicate part **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com> Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
add an e2e base setup file for the duplicate part
Requirements
Issue Fixed:
Notes for Reviewers: