Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add inference manifest template and generation script #833

Merged
merged 5 commits into from
Jan 21, 2025
Merged

refactor: add inference manifest template and generation script #833

merged 5 commits into from
Jan 21, 2025

Conversation

zhuangqh
Copy link
Collaborator

Reason for Change:

  • remove a lot of duplicate code in preset test
  • generate manifests using a script for normal model
  • using predefined manifest for llama

@zhuangqh
fix
1cd8c54 
Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
@zhuangqh
Copy link
Collaborator Author

zhuangqh commented Jan 20, 2025 •
edited
Loading

success
vllm https://github.com/kaito-project/kaito/actions/runs/12862614077/job/35859927725
hf https://github.com/kaito-project/kaito/actions/runs/12863744506/job/35875734822

Fei-Guo
Fei-Guo reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuangqh zhuangqh merged commit 9fe5b86 into main Jan 21, 2025
38 of 41 checks passed
@zhuangqh zhuangqh deleted the refactor-preset-tmpl branch January 21, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo left review comments

@ishaansehgal99 ishaansehgal99 ishaansehgal99 approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuangqh @ishaansehgal99 @Fei-Guo