Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade golangci-lint to v1.63.4 #821

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

rambohe-ch
Copy link
Collaborator

@rambohe-ch rambohe-ch commented Jan 13, 2025

Reason for Change:

golangci-lint v1.57 can not satisfy the requirement of v1.NodeClaim, so we need to upgrade golangci-lint before posting the v1.NodeClaim upgrade.

  1. upgrade golangci-lint to the v1.63.4 version
  2. configure golangci-lint to make gci checking, and make sure the package import orders should follow: standard --> normal --> kaito
  3. fix some other errors which has been triggered by new version golangci-lint, like ioutil, pointer, rand.Seed, etc.

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Jan 13, 2025

- make sure the package import orders should follow: standard --> normal --> kaito-project

Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
@Fei-Guo Fei-Guo merged commit c731441 into main Jan 13, 2025
7 of 8 checks passed
@Fei-Guo Fei-Guo deleted the upgrade-golangci-lint branch January 13, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants