Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove machine and aws/karpenter-core dependency from kaito #806

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat: remove machine and aws/karpenter-core dependency from kaito #806

merged 1 commit into from
Jan 13, 2025
+151 −1,692

Conversation

rambohe-ch
Copy link
Collaborator

@rambohe-ch rambohe-ch commented Jan 7, 2025 •
edited
Loading

Reason for Change:

  • remove machine and aws/karpenter-core dependency from kaito:

    1. remove machine resource
    2. remove aws/karpenter-core dependency
    3. upgrade gpu-provisioner version to v0.3.0(support nodeclaim api)
    4. improve WaitForPendingNodeClaims for making sure that nodeclaims are initialized before ensuring other resources.

Requirements

  • modified unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@rambohe-ch rambohe-ch changed the title [WIP] feat: remove machine and aws/karpenter-core dependency from kaito feat: remove machine and aws/karpenter-core dependency from kaito Jan 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 39.28571% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/ragengine/controllers/ragengine_controller.go 37.50% 9 Missing and 1 partial ⚠️
pkg/workspace/controllers/workspace_controller.go 41.17% 9 Missing and 1 partial ⚠️
...kg/ragengine/controllers/ragengine_gc_finalizer.go 0.00% 7 Missing ⚠️
pkg/utils/nodeclaim/nodeclaim.go 33.33% 2 Missing and 2 partials ⚠️
pkg/utils/common.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
pkg/featuregates/featuregates.go 100.00% <ø> (ø)
pkg/utils/test/mockClient.go 77.67% <ø> (-1.32%) ⬇️
pkg/utils/test/testUtils.go 100.00% <ø> (ø)
...kg/workspace/controllers/workspace_gc_finalizer.go 100.00% <100.00%> (ø)
pkg/utils/common.go 12.26% <0.00%> (+0.07%) ⬆️
pkg/utils/nodeclaim/nodeclaim.go 84.33% <33.33%> (-0.67%) ⬇️
...kg/ragengine/controllers/ragengine_gc_finalizer.go 0.00% <0.00%> (ø)
pkg/ragengine/controllers/ragengine_controller.go 41.05% <37.50%> (+3.57%) ⬆️
pkg/workspace/controllers/workspace_controller.go 40.68% <41.17%> (+1.75%) ⬆️

@rambohe-ch rambohe-ch changed the title feat: remove machine and aws/karpenter-core dependency from kaito [WIP] feat: remove machine and aws/karpenter-core dependency from kaito Jan 9, 2025
@zhuangqh
Copy link
Collaborator

why remove aws/karpenter-core dependency?

@rambohe-ch
feat: remove machine and aws/karpenter-core dependency from kaito
b571049 
1. remove machine resource
2. remove aws/karpenter-core dependency
3. upgrade gpu-provisioner version to v0.2.2(support nodeclaim api)
4. fix: make sure nodeclaims are initialized before ensuring other resources.

Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
@rambohe-ch
Copy link
Collaborator Author

why remove aws/karpenter-core dependency?

aws/karepenter-core repo is replaced by sigs.k8s.io/karpenter in karpenter community. so we don't need to keep both of them.

@rambohe-ch rambohe-ch changed the title [WIP] feat: remove machine and aws/karpenter-core dependency from kaito feat: remove machine and aws/karpenter-core dependency from kaito Jan 13, 2025
Fei-Guo
Fei-Guo reviewed Jan 13, 2025
View reviewed changes
@Fei-Guo Fei-Guo merged commit 8ad5146 into main Jan 13, 2025
9 of 10 checks passed
@Fei-Guo Fei-Guo deleted the remove-machine branch January 13, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuangqh zhuangqh zhuangqh approved these changes

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@ishaansehgal99 ishaansehgal99 Awaiting requested review from ishaansehgal99 ishaansehgal99 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rambohe-ch @codecov-commenter @zhuangqh @Fei-Guo