Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add inference config api #791

Merged
merged 3 commits into from
Dec 26, 2024
Merged

feat: add inference config api #791

merged 3 commits into from
Dec 26, 2024

Conversation

zhuangqh
Copy link
Collaborator

Reason for Change:

  • API change: add config to workspace.inference.config
  • generate a default config if no user config specified by copying from release-namespace

Requirements

  • added unit tests and e2e tests (if applicable).

@zhuangqh
feat: add inference config api
25f1f98 
- API change: add config to workspace.inference.config
- generate a default config if no user config specified
  by copying from release-namespace

Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
Fei-Guo
Fei-Guo reviewed Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the default inference configmap?

@zhuangqh
Copy link
Collaborator Author

where is the default inference configmap?

https://github.com/kaito-project/kaito/blob/main/charts/kaito/workspace/templates/inference-params.yaml here.

@Fei-Guo Fei-Guo merged commit d9dc364 into kaito-project:main Dec 26, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@ishaansehgal99 ishaansehgal99 Awaiting requested review from ishaansehgal99 ishaansehgal99 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhuangqh @Fei-Guo