feat: RAGEngine update and validation #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangqh
approved these changes
Dec 3, 2024
Fei-Guo
reviewed
Dec 3, 2024
| if deployment.Annotations[kaitov1alpha1.RAGEngineRevisionAnnotation] != revisionStr { | ||
| var volumes []corev1.Volume | ||
| var volumeMounts []corev1.VolumeMount | ||
| shmVolume, shmVolumeMount := utils.ConfigSHMVolume(*ragEngineObj.Spec.Compute.Count) |
There was a problem hiding this comment.
Do we need shmvolumes for rag engine?
There was a problem hiding this comment.
I believe only if they use GPU node
9f678e1 to
c4db408
Compare
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
c4db408 to
2d0810e
Compare
Fei-Guo
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add Update part of RAGEngine controller and validation
Requirements
Issue Fixed:
Notes for Reviewers: