fix: create the workspace service for custom models #745
+53
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This change updates the
ensureService
function in the workspace controller to create the workspace service for custom models instead of only doing it for preset models.The logic today only goes into the service creation code if there is a preset, but it is only using the preset information to see if the model supports distributed inference. To add support for custom models, we can just default the distributed inference support to false and always create the service preset or not.
It seems fair to me to only support distributed inference on the preset models as that requires more setup. With this change custom models can at least have basic support without any manual Kubernetes resource creation.
Fixes #744.
Requirements
Issue Fixed:
Fixes #744
Notes for Reviewers: