Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tuning test to preset test #741

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat: add tuning test to preset test #741

merged 2 commits into from
Nov 28, 2024

Conversation

zhuangqh
Copy link
Collaborator

@zhuangqh zhuangqh commented Nov 27, 2024 •
edited
Loading

Reason for Change:

  • add tuning test to preset test
  • remove extra preset manifests

@zhuangqh
feat: add tuning test to preset test
a7f1897 
Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
@zhuangqh zhuangqh marked this pull request as ready for review November 27, 2024 11:42
ishaansehgal99
ishaansehgal99 reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete all the preset/workspace/test/manifests? Still used by e2e preset tests

@zhuangqh
use config
882de58 
Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
ishaansehgal99
ishaansehgal99 reviewed Nov 28, 2024
View reviewed changes
.github/workflows/e2e-preset-tuning-test.yml
Comment on lines +44 to +47
- name: Get test meta
id: get_test_meta
run: |
CONFIG=$(jq '.matrix.image[] | select(.name == "tuning-example")' .github/e2e-preset-configs.json)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@ishaansehgal99 ishaansehgal99 merged commit 2cb5710 into main Nov 28, 2024
3 of 6 checks passed
@ishaansehgal99 ishaansehgal99 deleted the preset-tuning-test branch November 28, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaansehgal99 ishaansehgal99 ishaansehgal99 approved these changes

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuangqh @ishaansehgal99 @Fei-Guo