Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update helm list command in installation guide to use new namespaces. #730

Merged
merged 2 commits into from
Nov 25, 2024
Merged

docs: Update helm list command in installation guide to use new namespaces. #730

merged 2 commits into from
Nov 25, 2024

Conversation

abenn135
Copy link
Collaborator

Reason for Change:

Fix to onboarding documentation. New users might be surprised to find no helm deployments when in fact they were pushed correctly.

Requirements

  • added unit tests and e2e tests (if applicable). N/A

Issue Fixed:

None

Notes for Reviewers:

Fix after #706.

@Fei-Guo Fei-Guo changed the title Update helm list command in installation guide to use new namespaces. docs: Update helm list command in installation guide to use new namespaces. Nov 25, 2024
@Fei-Guo Fei-Guo merged commit 2139dfe into main Nov 25, 2024
4 of 5 checks passed
@Fei-Guo Fei-Guo deleted the alexbenn/fix-docs-ns branch November 25, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@ishaansehgal99 ishaansehgal99 Awaiting requested review from ishaansehgal99 ishaansehgal99 is a code owner

@zhuangqh zhuangqh Awaiting requested review from zhuangqh zhuangqh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abenn135 @Fei-Guo