Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate workspace name #726

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: Validate workspace name #726

merged 2 commits into from
Nov 28, 2024

Conversation

zhuangqh
Copy link
Collaborator

@zhuangqh zhuangqh commented Nov 25, 2024 •
edited
Loading

Reason for Change:

check if it is a valid DNSLabel

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Fixes #725

Notes for Reviewers:

@zhuangqh
fix: validate workspace name
f429b32 
check if it is a valid DNSLabel

Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
@zhuangqh
update name
a4acc85 
Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
@ishaansehgal99 ishaansehgal99 changed the title fix: validate workspace name fix: Validate workspace name Nov 28, 2024
@ishaansehgal99 ishaansehgal99 merged commit 3dbb660 into kaito-project:main Nov 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaansehgal99 ishaansehgal99 ishaansehgal99 approved these changes

@bangqipropel bangqipropel bangqipropel approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot create service for workspace
3 participants
@zhuangqh @ishaansehgal99 @bangqipropel