Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove instanceType field in aks arc doc and rename HCI to Azure Local #702

Merged
merged 11 commits into from
Dec 7, 2024
Merged

Remove instanceType field in aks arc doc and rename HCI to Azure Local #702

merged 11 commits into from
Dec 7, 2024

Conversation

qfai
Copy link
Contributor

@qfai qfai commented Nov 18, 2024

Reason for Change:

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@qfai qfai changed the title Remove instanceType field in doc and rename HCI to Azure Local Remove instanceType field in aks arc doc and rename HCI to Azure Local Nov 18, 2024
ishaansehgal99
ishaansehgal99 requested changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

Fei-Guo
Fei-Guo approved these changes Dec 7, 2024
View reviewed changes
@Fei-Guo Fei-Guo merged commit 11f9cd1 into kaito-project:main Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaansehgal99 ishaansehgal99 ishaansehgal99 requested changes

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@zhuangqh zhuangqh Awaiting requested review from zhuangqh zhuangqh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qfai @ishaansehgal99 @Fei-Guo