chore: refactor to move ragengine to a central package #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangqh
approved these changes
Nov 5, 2024
bangqipropel
approved these changes
Nov 5, 2024
ishaansehgal99
approved these changes
Nov 5, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Nov 14, 2024
…#671) This change attempts to move ragengine controller and service code under pkg/ragengine. Some common codes and labels are moved to pkg/utils and pkg/utils/consts. There are no functionality changes. Notes: This change adds fail faster to e2e test and will keep the failed workspace undeleted (so that the workload pod log can be printed). --------- Co-authored-by: Bangqi Zhu <68867834+bangqipropel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to move ragengine controller and service code under pkg/ragengine.
Some common codes and labels are moved to pkg/utils and pkg/utils/consts.
There are no functionality changes.
Notes:
This change adds fail faster to e2e test and will keep the failed workspace undeleted (so that the workload pod log can be printed).