fix: patch imagePullSecrets validation in e2e test #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qfai this is a patch of your PR, remove the imagePullSecrets validation for the first adapter image |
4193d4f to
9903913
Compare
c053b75 to
e0fa164
Compare
e0fa164 to
2a11ab3
Compare
2a11ab3 to
fe0d4f8
Compare
fe0d4f8 to
816f88b
Compare
816f88b to
c33cef2
Compare
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
c33cef2 to
4c22046
Compare
Fei-Guo
approved these changes
Nov 3, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Nov 14, 2024
**Reason for Change**: patch imagePullSecrets validation in e2e test, only the second image need this check **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
zhuangqh
pushed a commit
that referenced
this pull request
Nov 15, 2024
**Reason for Change**: patch imagePullSecrets validation in e2e test, only the second image need this check **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
patch imagePullSecrets validation in e2e test, only the second image need this check
Requirements
Issue Fixed:
Notes for Reviewers: