feat: Add delete and finalizer to RAGEngine #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2024 02:05
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 58.18% 52.09% -6.10%
==========================================
Files 30 35 +5
Lines 2987 4279 +1292
==========================================
+ Hits 1738 2229 +491
- Misses 1149 1930 +781
- Partials 100 120 +20 ☔ View full report in Codecov by Sentry. |
zhuangqh
reviewed
Oct 23, 2024
c4c4c43 to
fc7e596
Compare
zhuangqh
approved these changes
Oct 28, 2024
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
665bd0a to
b22046c
Compare
Fei-Guo
approved these changes
Oct 29, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Nov 14, 2024
**Reason for Change**: Add delete and finalizer to RAGEngine **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add delete and finalizer to RAGEngine
Requirements
Issue Fixed:
Notes for Reviewers: