Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add printcolumn to RAG Engine #623

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:
add printcolumn to RAG Engine

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 42.11765% with 246 lines in your changes missing coverage. Please review.

Project coverage is 53.40%. Comparing base (5c30038) to head (9436826).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/ragengine_controller.go 27.94% 152 Missing and 13 partials ⚠️
pkg/nodeclaim/nodeclaim.go 63.49% 23 Missing ⚠️
pkg/machine/machine.go 64.00% 18 Missing ⚠️
api/v1alpha1/ragenging_validation.go 0.00% 14 Missing ⚠️
pkg/webhooks/webhooks.go 0.00% 14 Missing ⚠️
pkg/controllers/workspace_controller.go 43.75% 9 Missing ⚠️
pkg/controllers/ragengine_status.go 94.73% 1 Missing and 1 partial ⚠️
api/v1alpha1/ragengine_default.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   58.18%   53.40%   -4.79%     
==========================================
  Files          30       34       +4     
  Lines        2987     3500     +513     
==========================================
+ Hits         1738     1869     +131     
- Misses       1149     1516     +367     
- Partials      100      115      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@Fei-Guo Fei-Guo merged commit 791c175 into main Oct 23, 2024
4 of 6 checks passed
@Fei-Guo Fei-Guo deleted the bangqipropel/add_rag_printcolumn branch October 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants