Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update of functions related to nodeclaim and machine for RAG engine #620

Merged
merged 2 commits into from
Oct 9, 2024
Merged

feat: update of functions related to nodeclaim and machine for RAG engine #620

merged 2 commits into from
Oct 9, 2024
+137 −50

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Oct 9, 2024 •
edited
Loading

Reason for Change:
update of functions related to nodeclaim and machine for RAG engine

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@bangqipropel bangqipropel force-pushed the bangqipropel/reuse_Node_provision branch from f8fd204 to 9e32ece Compare October 9, 2024 07:43
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.71681% with 41 lines in your changes missing coverage. Please review.

Project coverage is 54.71%. Comparing base (5c30038) to head (3066117).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nodeclaim/nodeclaim.go 63.49% 23 Missing ⚠️
pkg/machine/machine.go 64.00% 18 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   58.18%   54.71%   -3.47%     
==========================================
  Files          30       33       +3     
  Lines        2987     3233     +246     
==========================================
+ Hits         1738     1769      +31     
- Misses       1149     1363     +214     
- Partials      100      101       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Clusterrole and webhook update
c47727f 
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel force-pushed the bangqipropel/reuse_Node_provision branch from 980850c to fe92f42 Compare October 9, 2024 18:08
@bangqipropel bangqipropel force-pushed the bangqipropel/reuse_Node_provision branch from fe92f42 to 3066117 Compare October 9, 2024 18:11
Fei-Guo
Fei-Guo reviewed Oct 9, 2024
View reviewed changes
update of functions related to nodeclaim and machine for reuse
25e7ab8 
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel force-pushed the bangqipropel/reuse_Node_provision branch from 3066117 to 25e7ab8 Compare October 9, 2024 22:38
@Fei-Guo Fei-Guo merged commit f613bb4 into main Oct 9, 2024
4 of 6 checks passed
@Fei-Guo Fei-Guo deleted the bangqipropel/reuse_Node_provision branch October 9, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaansehgal99 ishaansehgal99 ishaansehgal99 approved these changes

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bangqipropel @ishaansehgal99 @Fei-Guo