Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clusterrole and Webhook update for RAG Engine #619

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Oct 9, 2024

Reason for Change:
Clusterrole and Webhook update for RAG Engine

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@bangqipropel bangqipropel changed the title feat: Clusterrole and webhook update feat: Clusterrole and Webhook update for RAG Engine Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 54.95%. Comparing base (5c30038) to head (f3d58ec).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
api/v1alpha1/ragengine_validation.go 0.00% 14 Missing ⚠️
pkg/webhooks/webhooks.go 0.00% 14 Missing ⚠️
api/v1alpha1/ragengine_default.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   58.18%   54.95%   -3.24%     
==========================================
  Files          30       33       +3     
  Lines        2987     3159     +172     
==========================================
- Hits         1738     1736       -2     
- Misses       1149     1322     +173     
- Partials      100      101       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@Fei-Guo Fei-Guo merged commit 38656dd into main Oct 9, 2024
5 of 8 checks passed
@Fei-Guo Fei-Guo deleted the bangqipropel/Clusterrole_webhook_RAG branch October 9, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants