fix: ignore instanceType when selecting preferred nodes #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 58.18% 55.39% -2.80%
==========================================
Files 30 31 +1
Lines 2987 3134 +147
==========================================
- Hits 1738 1736 -2
- Misses 1149 1297 +148
- Partials 100 101 +1 ☔ View full report in Codecov by Sentry. |
Fei-Guo
approved these changes
Oct 9, 2024
zhuangqh
added a commit
that referenced
this pull request
Nov 14, 2024
**Reason for Change**: <!-- What does this PR improve or fix in Kaito? Why is it needed? --> ignore instanceType when selecting preferred nodes **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
zhuangqh
added a commit
that referenced
this pull request
Nov 14, 2024
**Reason for Change**: <!-- What does this PR improve or fix in Kaito? Why is it needed? --> ignore instanceType when selecting preferred nodes **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
zhuangqh
added a commit
that referenced
this pull request
Nov 14, 2024
**Reason for Change**: <!-- What does this PR improve or fix in Kaito? Why is it needed? --> ignore instanceType when selecting preferred nodes **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
ignore instanceType when selecting preferred nodes
Requirements
Issue Fixed:
Notes for Reviewers: