Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ragengine controller scaffolding code and chart #600

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

Fei-Guo
Copy link
Collaborator

@Fei-Guo Fei-Guo commented Sep 19, 2024

This PR adds the related scaffolding code/chart for the ragengine controller.

  • Create a new directory in /cmd to hold the ragengine main package. Move workspace main package to /cmd/workspace
  • Create pkg/controllers/ragengine_controller.go with minimum code required to run a controller.
  • Add entries in Makefile for build binary and image.
  • Add a new helm chart for installing ragengine controller deployment.
    -- The major change is that I add fullnameOverride: ragengine in values.yaml so that I can largely reuse the existing chart for workpsace.

Testing:

I can build kaito/ragengine:0.0.1 in my acr by running make docker-build-ragengine

helm install ragengine ./charts/kaito/ragengine --set image.repository=guofei.azurecr.io/kaito/ragengine --set 
 image.tag=0.0.1 --namespace ragengine --create-namespace
NAME: ragengine
LAST DEPLOYED: Thu Sep 19 10:31:04 2024
NAMESPACE: ragengine
STATUS: deployed
REVISION: 1
TEST SUITE: None

 k get pod -n ragengine
NAME                         READY   STATUS    RESTARTS   AGE
ragengine-5756f8f58f-smmhl   1/1     Running   0          73s

k logs ragengine-5756f8f58f-smmhl -n ragengine
I0919 17:31:14.940028       1 main.go:153] "starting manager"
2024-09-19T17:31:14Z    INFO    controller-runtime.metrics      Starting metrics server
2024-09-19T17:31:14Z    INFO    controller-runtime.metrics      Serving metrics server  {"bindAddress": ":8080", "secure": false}
2024-09-19T17:31:14Z    INFO    starting server {"name": "health probe", "addr": "[::]:8081"}
2024-09-19T17:31:14Z    INFO    Starting EventSource    {"controller": "ragengine", "controllerGroup": "kaito.sh", "controllerKind": "RAGEngine", "source": "kind source: *v1alpha1.RAGEngine"}
2024-09-19T17:31:14Z    INFO    Starting Controller     {"controller": "ragengine", "controllerGroup": "kaito.sh", "controllerKind": "RAGEngine"}
2024-09-19T17:31:16Z    INFO    Starting workers        {"controller": "ragengine", "controllerGroup": "kaito.sh", "controllerKind": "RAGEngine", "worker count": 5}

@Fei-Guo Fei-Guo merged commit ba1a62d into main Sep 21, 2024
6 of 8 checks passed
@Fei-Guo Fei-Guo deleted the fguo-dev1 branch September 21, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants