fix: Check HTTP Status code for curl download #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
- Coverage 58.18% 57.69% -0.49%
==========================================
Files 30 30
Lines 2987 2988 +1
==========================================
- Hits 1738 1724 -14
- Misses 1149 1164 +15
Partials 100 100 ☔ View full report in Codecov by Sentry. |
Fei-Guo
approved these changes
Aug 30, 2024
bangqipropel
approved these changes
Aug 31, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Sep 18, 2024
**Reason for Change**: For some URLs, curl command won't return an error code and will output an empty file. This causes data-downloader init container to pass when it shouldn't. In this PR we explicitly check the HTTP status code to ensure the dataset downloaded completed successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
For some URLs, curl command won't return an error code and will output an empty file. This causes data-downloader init container to pass when it shouldn't.
In this PR we explicitly check the HTTP status code to ensure the dataset downloaded completed successfully.