test: Add e2e tests for azure karpenter #573
Merged
+234
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
430e104 to
96c9f69
Compare
96c9f69 to
d30b48c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
+ Coverage 56.54% 58.19% +1.65%
==========================================
Files 30 30
Lines 2966 2978 +12
==========================================
+ Hits 1677 1733 +56
+ Misses 1191 1144 -47
- Partials 98 101 +3 ☔ View full report in Codecov by Sentry. |
| @@ -53,13 +53,10 @@ az identity federated-credential create --name "${FED_NAME}" \ | |||
|
|
|||
| if [[ "${COMPONENT_NAME}" == "azkarpenter" ]]; then | |||
| echo "Creating role assignments for $COMPONENT_NAME ..." | |||
| for role in "Virtual Machine Contributor" "Network Contributor" "Managed Identity Operator" "Contributor"; do | |||
| for role in "Virtual Machine Contributor" "Network Contributor" "Managed Identity Operator"; do | |||
There was a problem hiding this comment.
nice! you were able to remove contributor acces
Fei-Guo
reviewed
Aug 21, 2024
test/e2e/preset_test.go
Outdated
| @@ -612,7 +573,12 @@ var _ = Describe("Workspace Preset", func() { | |||
| defer cleanupResources(workspaceObj) | |||
| time.Sleep(30 * time.Second) | |||
|
|
|||
| validateMachineCreation(workspaceObj, numOfNode) | |||
| if nodeProvisionerName == "azkarpenter" { | |||
There was a problem hiding this comment.
Can you make a common function for this to avoid code duplication in this file?
ishaansehgal99
approved these changes
Aug 21, 2024
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
ba7220b to
dffde52
Compare
Fei-Guo
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: