-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e test for updating adapters #566
Merged
bangqipropel
merged 1 commit into
main
from
bangqipropel/test_for_wrong_safetensor_file
Aug 28, 2024
Merged
test: add e2e test for updating adapters #566
bangqipropel
merged 1 commit into
main
from
bangqipropel/test_for_wrong_safetensor_file
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f246f6f
to
2d63e0f
Compare
2d63e0f
to
dcdda7a
Compare
dcdda7a
to
fff78eb
Compare
fff78eb
to
e478af1
Compare
e478af1
to
ab87ec0
Compare
9fad91c
to
33682c7
Compare
Fei-Guo
reviewed
Aug 28, 2024
c702703
to
52032ac
Compare
52032ac
to
d197e6c
Compare
ishaansehgal99
approved these changes
Aug 28, 2024
d197e6c
to
24b671a
Compare
Fei-Guo
approved these changes
Aug 28, 2024
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
24b671a
to
dbd3d13
Compare
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Sep 18, 2024
**Reason for Change**: Add e2e tests for updating adapters and validation of it Add controller revision validation to e2e test **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add e2e tests for updating adapters and validation of it
Add controller revision validation to e2e test
Requirements
Issue Fixed:
Notes for Reviewers: