Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test for updating adapters #566

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Aug 16, 2024

Reason for Change:
Add e2e tests for updating adapters and validation of it
Add controller revision validation to e2e test

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from f246f6f to 2d63e0f Compare August 16, 2024 09:29
@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from 2d63e0f to dcdda7a Compare August 26, 2024 22:17
@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from dcdda7a to fff78eb Compare August 26, 2024 22:18
@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from fff78eb to e478af1 Compare August 26, 2024 22:44
@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from e478af1 to ab87ec0 Compare August 26, 2024 22:53
@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from 9fad91c to 33682c7 Compare August 27, 2024 21:34
@bangqipropel bangqipropel changed the title chore: add e2e test for updating adapters test: add e2e test for updating adapters Aug 28, 2024
@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from d197e6c to 24b671a Compare August 28, 2024 18:46
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel force-pushed the bangqipropel/test_for_wrong_safetensor_file branch from 24b671a to dbd3d13 Compare August 28, 2024 19:24
@bangqipropel bangqipropel merged commit 61d9a1f into main Aug 28, 2024
7 of 8 checks passed
@bangqipropel bangqipropel deleted the bangqipropel/test_for_wrong_safetensor_file branch August 28, 2024 21:24
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Sep 18, 2024
**Reason for Change**:
Add e2e tests for updating adapters and validation of it
Add controller revision validation to e2e test

**Requirements**

- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
<!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
line. -->

**Notes for Reviewers**:

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants