Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update controllerRevision and deployment lifecycle #559

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Aug 14, 2024

Reason for Change:

  1. Change "workspace.kaito.io/revision" to revision number, and make the hash result as "workspace.kaito.io/hash"
  2. Sync contropllerrevision and workspace at the beginning of the Reconcile
  3. Update the tests for the changes

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 24 lines in your changes missing coverage. Please review.

Project coverage is 58.18%. Comparing base (8e8581e) to head (fcc166b).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/controllers/workspace_controller.go 67.12% 15 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   58.09%   58.18%   +0.08%     
==========================================
  Files          30       30              
  Lines        2983     2987       +4     
==========================================
+ Hits         1733     1738       +5     
  Misses       1149     1149              
+ Partials      101      100       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bangqipropel bangqipropel force-pushed the bangqipropel/Create_ControllerRevision branch from 431ea09 to 87fe770 Compare August 15, 2024 05:05
@bangqipropel bangqipropel changed the title feat: Create ControllerRevision with deployment[draft] feat: Create ControllerRevision with deployment Aug 15, 2024
@bangqipropel bangqipropel force-pushed the bangqipropel/Create_ControllerRevision branch from 87fe770 to 4418240 Compare August 20, 2024 00:11
@bangqipropel bangqipropel force-pushed the bangqipropel/Create_ControllerRevision branch from 4418240 to d20ac5a Compare August 20, 2024 10:00
@bangqipropel bangqipropel force-pushed the bangqipropel/Create_ControllerRevision branch from d20ac5a to b521932 Compare August 20, 2024 11:09
@bangqipropel bangqipropel force-pushed the bangqipropel/Create_ControllerRevision branch from b521932 to f026a31 Compare August 20, 2024 18:00
@bangqipropel bangqipropel changed the title feat: Create ControllerRevision with deployment feat: Update controllerRevision and deployment lifecycle Aug 20, 2024
@bangqipropel bangqipropel force-pushed the bangqipropel/Create_ControllerRevision branch from f026a31 to c6ee457 Compare August 20, 2024 18:17
@bangqipropel bangqipropel force-pushed the bangqipropel/Create_ControllerRevision branch from c6ee457 to 2f28063 Compare August 21, 2024 08:56
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel merged commit 1afb924 into main Aug 23, 2024
9 checks passed
@bangqipropel bangqipropel deleted the bangqipropel/Create_ControllerRevision branch August 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants