Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep Docker Sidecar Alive for Data Retrieval #552

Merged
merged 18 commits into from
Aug 15, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Aug 8, 2024

Reason for Change:

  • Keep the docker sidecar container alive so incase ACR push fails we can still exec into the container to retrieve completed tuning job files in the /mnt/results folder.

  • Perform validation check for output images that are uppercase

  • Use projected volume for mounting docker config secrets - mount at directory location /root/.docker/config

  • Add secret for E2E Temp ACR

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 11.59420% with 61 lines in your changes missing coverage. Please review.

Project coverage is 56.54%. Comparing base (ed546f0) to head (46b0ed1).
Report is 37 commits behind head on main.

Files Patch % Lines
pkg/tuning/preset-tuning.go 0.00% 34 Missing ⚠️
pkg/utils/common-preset.go 0.00% 13 Missing ⚠️
pkg/controllers/workspace_controller.go 0.00% 7 Missing ⚠️
pkg/utils/common.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   61.10%   56.54%   -4.57%     
==========================================
  Files          29       30       +1     
  Lines        2602     2966     +364     
==========================================
+ Hits         1590     1677      +87     
- Misses        921     1191     +270     
- Partials       91       98       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 merged commit 8b7aabf into main Aug 15, 2024
7 of 9 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/keep-sidecar-alive branch August 15, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants